1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
use merino_suggest_traits::Suggestion;
use redis::{FromRedisValue, ToRedisArgs};
const SERIALIZATION_VERSION: &[u8] = b"v0";
pub(crate) struct RedisSuggestions(pub(crate) Vec<Suggestion>);
impl FromRedisValue for RedisSuggestions {
fn from_redis_value(v: &redis::Value) -> redis::RedisResult<Self> {
match v {
redis::Value::Data(bytes) => {
if &bytes[..2] != SERIALIZATION_VERSION {
return Err((
redis::ErrorKind::TypeError,
"Unexpected cache serialization version `{}`.",
String::from_utf8_lossy(&bytes[..2]).to_string(),
)
.into());
}
serde_json::from_slice(&bytes[2..])
.map_err(|error| {
(
redis::ErrorKind::TypeError,
"Could not deserialize data from Redis",
format!("{:?}", error),
)
.into()
})
.map(Self)
}
v => Err((
redis::ErrorKind::TypeError,
"Invalid type received from Redis. Expected `Data`",
format!("Got {:?}", v),
)
.into()),
}
}
}
impl ToRedisArgs for RedisSuggestions {
fn write_redis_args<W>(&self, out: &mut W)
where
W: ?Sized + redis::RedisWrite,
{
let serialized = serde_json::to_string(&self.0).expect("Bug: cannot serialize suggestions");
let mut output = String::from_utf8(SERIALIZATION_VERSION.to_vec())
.expect("Bug: serialization version is not utf8");
output.push_str(&serialized);
out.write_arg(output.as_bytes())
}
}
impl From<RedisSuggestions> for Vec<Suggestion> {
fn from(val: RedisSuggestions) -> Self {
val.0
}
}
#[derive(Debug, PartialEq, Eq, Clone, Copy)]
pub enum RedisTtl {
KeyDoesNotExist,
KeyHasNoTtl,
Ttl(usize),
}
impl FromRedisValue for RedisTtl {
fn from_redis_value(v: &redis::Value) -> redis::RedisResult<Self> {
match v {
redis::Value::Int(ttl) if *ttl >= 0 => Ok(Self::Ttl(*ttl as usize)),
redis::Value::Int(ttl) if *ttl == -1 => Ok(Self::KeyHasNoTtl),
redis::Value::Int(ttl) if *ttl == -2 => Ok(Self::KeyDoesNotExist),
redis::Value::Int(_) => Err((
redis::ErrorKind::TypeError,
"Invalid value received from Redis. Expected a non-negative integer, -1, or -2",
)
.into()),
_ => Err((
redis::ErrorKind::TypeError,
"Invalid type received from Redis. Expected `Int`",
)
.into()),
}
}
}
#[cfg(test)]
mod tests {
use anyhow::{anyhow, Result};
use http::Uri;
use merino_suggest_traits::{Proportion, Suggestion};
use proptest::prelude::*;
use redis::{FromRedisValue, ToRedisArgs};
use crate::redis::domain::{RedisSuggestions, RedisTtl, SERIALIZATION_VERSION};
#[test]
fn can_convert_redis_value_to_suggestions() -> Result<()> {
let original_suggestions = vec![Suggestion {
id: 1,
full_keyword: "one".to_string(),
title: "One".to_string(),
url: Uri::from_static("https://example.com/target/one"),
impression_url: Some(Uri::from_static("https://example.com/impression/one")),
click_url: Some(Uri::from_static("https://example.com/click/one")),
provider: "One Inc.".to_string(),
advertiser: "One Inc.".to_string(),
is_sponsored: true,
icon: Uri::from_static("https://example.com/icon/one.png"),
score: Proportion::zero(),
}];
let mut serialized = SERIALIZATION_VERSION.to_vec();
serialized.extend_from_slice(&serde_json::to_vec(&original_suggestions)?);
let redis_value = redis::Value::Data(serialized);
let deserialized = RedisSuggestions::from_redis_value(&redis_value)?;
assert_eq!(original_suggestions, deserialized.0);
Ok(())
}
#[test]
fn invalid_serialization_version_produces_an_error() -> Result<()> {
let redis_value = redis::Value::Data("vXbad version".as_bytes().to_vec());
let error = RedisSuggestions::from_redis_value(&redis_value)
.err()
.ok_or_else(|| anyhow!("expected error"))?;
assert_eq!(error.kind(), redis::ErrorKind::TypeError);
assert!(error.to_string().contains("version"));
assert_eq!(
error.detail().ok_or_else(|| anyhow!("no error detail"))?,
"vX"
);
Ok(())
}
#[test]
fn invalid_serialization_json_produces_an_error() -> Result<()> {
let redis_value = redis::Value::Data(r#"v0["bad_json"#.as_bytes().to_vec());
let error = RedisSuggestions::from_redis_value(&redis_value)
.err()
.ok_or_else(|| anyhow!("expected error"))?;
dbg!(&error);
assert_eq!(error.kind(), redis::ErrorKind::TypeError);
assert!(error.to_string().contains("Could not deserialize"));
assert!(error
.detail()
.ok_or_else(|| anyhow!("no error detail"))?
.contains("EOF while parsing a string"));
Ok(())
}
#[test]
fn other_redis_values_cannot_be_converted_to_suggestions() -> Result<()> {
assert!(RedisSuggestions::from_redis_value(&redis::Value::Nil).is_err());
assert!(RedisSuggestions::from_redis_value(&redis::Value::Int(42)).is_err());
assert!(RedisSuggestions::from_redis_value(&redis::Value::Bulk(vec![])).is_err());
assert!(RedisSuggestions::from_redis_value(&redis::Value::Status(
"unexpected".to_string()
))
.is_err());
assert!(RedisSuggestions::from_redis_value(&redis::Value::Okay).is_err());
Ok(())
}
#[test]
fn can_convert_suggestions_to_redis_arg() -> Result<()> {
let original_suggestions = vec![Suggestion {
id: 1,
full_keyword: "one".to_string(),
title: "One".to_string(),
url: Uri::from_static("https://example.com/target/one"),
impression_url: Some(Uri::from_static("https://example.com/impression/one")),
click_url: Some(Uri::from_static("https://example.com/click/one")),
provider: "One Inc.".to_string(),
advertiser: "One Inc.".to_string(),
is_sponsored: true,
icon: Uri::from_static("https://example.com/icon/one.png"),
score: Proportion::zero(),
}];
let val = RedisSuggestions(original_suggestions.clone()).to_redis_args();
assert_eq!(val.len(), 1);
assert_eq!(&val[0][..2], SERIALIZATION_VERSION);
let parsed_suggestions: Vec<Suggestion> = serde_json::from_slice(&val[0][2..])?;
assert_eq!(parsed_suggestions, original_suggestions);
Ok(())
}
#[test]
fn from_redis_suggestion_for_vec_suggestions() {
let suggestions = RedisSuggestions(vec![]);
let expected: Vec<Suggestion> = vec![];
let actual: Vec<Suggestion> = suggestions.into();
assert_eq!(actual, expected);
}
#[test]
fn can_convert_redis_value_to_ttl() -> Result<()> {
assert_eq!(
RedisTtl::from_redis_value(&redis::Value::Int(-2))?,
RedisTtl::KeyDoesNotExist
);
assert_eq!(
RedisTtl::from_redis_value(&redis::Value::Int(-1))?,
RedisTtl::KeyHasNoTtl
);
assert_eq!(
RedisTtl::from_redis_value(&redis::Value::Int(0))?,
RedisTtl::Ttl(0)
);
Ok(())
}
#[test]
fn ttl_type_errors_are_handled() {
assert!(RedisTtl::from_redis_value(&redis::Value::Nil).is_err());
assert!(RedisTtl::from_redis_value(&redis::Value::Okay).is_err());
assert!(
RedisTtl::from_redis_value(&redis::Value::Status("unexpected".to_string())).is_err()
);
assert!(RedisTtl::from_redis_value(&redis::Value::Data(b"unexpected".to_vec())).is_err());
assert!(RedisTtl::from_redis_value(&redis::Value::Bulk(vec![])).is_err());
}
proptest! {
#[test]
fn can_convert_valid_ttl_values(ttl in 0_i64..) {
let res = RedisTtl::from_redis_value(&redis::Value::Int(ttl));
prop_assert_eq!(res, Ok(RedisTtl::Ttl(ttl as usize)));
}
#[test]
fn invalid_ttls_make_errors(ttl in ..-2_i64) {
let res = RedisTtl::from_redis_value(&redis::Value::Int(ttl));
prop_assert_eq!(res.err().unwrap().kind(), redis::ErrorKind::TypeError);
}
}
}